cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Fix vm network throttling rate

Open iishitahere opened this issue 1 year ago • 4 comments

This PR addresses the issue with the vm.network.throttling.rate configuration in the cloud.configuration table. The change includes the addition of a default value for the vm.network.throttling.rate parameter, which defines the default data transfer rate in megabits per second allowed in user VM's default network.

Added a new configuration entry: Name: vm.network.throttling.rate Value: 200 (Default data transfer rate) Description: Default data transfer rate in megabits per second allowed in user VM's default network. This PR also removes the previous guest.ip.network and guest.netmask configuration entries, as per the requirements.

Changes made:

Inserted a new entry into the cloud.configuration table for the vm.network.throttling.rate. Deleted old configuration entries guest.ip.network and guest.netmask. Updated necessary code references. Note: A new branch has been created (fix-vm-network-throttling-rate) to reflect these changes.

iishitahere avatar Dec 14 '24 20:12 iishitahere

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 4.02%. Comparing base (54bc150) to head (befe864). Report is 31 commits behind head on main.

:exclamation: There is a different number of reports uploaded between BASE (54bc150) and HEAD (befe864). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (54bc150) HEAD (befe864)
unittests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##               main   #10109       +/-   ##
=============================================
- Coverage     16.06%    4.02%   -12.05%     
=============================================
  Files          5642      394     -5248     
  Lines        493856    32361   -461495     
  Branches      59860     5713    -54147     
=============================================
- Hits          79324     1301    -78023     
+ Misses       405749    30912   -374837     
+ Partials       8783      148     -8635     
Flag Coverage Δ
uitests 4.02% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 31 '24 06:12 codecov[bot]

@blueorangutan package

sureshanaparti avatar Jun 05 '25 09:06 sureshanaparti

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jun 05 '25 09:06 blueorangutan

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13620

blueorangutan avatar Jun 05 '25 11:06 blueorangutan

@iishitahere , closing this one as is old. please update and reopen if you think it is still relevant.

DaanHoogland avatar Dec 12 '25 09:12 DaanHoogland