cloudstack-terraform-provider icon indicating copy to clipboard operation
cloudstack-terraform-provider copied to clipboard

Add Override root disk offering and Disk Offerings to cloudstack_instance Resource

Open jb2592 opened this issue 2 years ago • 2 comments

It would be useful to be able to override the root disk offering as part of the compute offering and specify a disk offering as part of the cloudstack_instance resource just like you can via the UI.

Select a Compute Offering Enable Override root disk offering Select a disk offering via name or ID from the list available.

jb2592 avatar Aug 08 '23 19:08 jb2592

@vishesh92

We need to add the parameter "overridediskofferingid" to the resource cloudstack_instance

https://cloudstack.apache.org/api/apidocs-4.19/apis/deployVirtualMachine.html

https://github.com/apache/cloudstack-terraform-provider/blob/main/cloudstack/resource_cloudstack_instance.go

https://github.com/apache/cloudstack-go/blob/main/cloudstack/VirtualMachineService.go#L40

When I added the following code and try to build it locally getting the following exception

"overridediskofferingid": {
				Type:     schema.TypeString,
				Optional: true,
			},
			

if overridediskofferingid, ok := d.GetOk("overridediskofferingid"); ok {
		p.SetOverridediskofferingid(overridediskofferingid.(string))
	}

cloudstack-terraform-provider git:(add-overridediskofferingid) ✗ go build
# github.com/terraform-providers/terraform-provider-cloudstack/cloudstack
cloudstack/resource_cloudstack_instance.go:291:5: p.SetOverridediskofferingid undefined (type *"github.com/apache/cloudstack-go/v2/cloudstack".DeployVirtualMachineParams has no field or method SetOverridediskofferingid)

kiranchavala avatar Mar 05 '24 12:03 kiranchavala

Had a discussion with @kiranchavala. This requires go SDK to be upgraded. Changed the milestone to v0.6.0

vishesh92 avatar Mar 06 '24 09:03 vishesh92