cloudstack-terraform-provider icon indicating copy to clipboard operation
cloudstack-terraform-provider copied to clipboard

Fix update of VM details

Open vishesh92 opened this issue 10 months ago • 3 comments
trafficstars

Fixes #58 #148

vishesh92 avatar Jan 24 '25 09:01 vishesh92

@vishesh92 please see #148 as there are still issues

CodeBleu avatar Feb 04 '25 15:02 CodeBleu

@vishesh92 please see #148 as there are still issues

@CodeBleu can you be more specific? for instance ; is this PR not fixing anything? if it is, can you create a sub issue to spilt out the remaining issue? I am looking to merge a couple of PRs but don't want to cut anybody in the foot doing so ;)

DaanHoogland avatar Apr 11 '25 08:04 DaanHoogland

@vishesh92 please see #148 as there are still issues

@CodeBleu can you be more specific? for instance ; is this PR not fixing anything? if it is, can you create a sub issue to spilt out the remaining issue? I am looking to merge a couple of PRs but don't want to cut anybody in the foot doing so ;)

Not sure what else to say. All the details are in #148 The details of this PR not working for me are here: https://github.com/apache/cloudstack-terraform-provider/issues/148#issuecomment-2634288870

CodeBleu avatar Apr 11 '25 12:04 CodeBleu

https://cloudstack.apache.org/api/apidocs-4.21/apis/updateVirtualMachine.html

I checked this and this is due to a bug in cloudstack-go SDK.

vishesh92 avatar Sep 01 '25 07:09 vishesh92

https://cloudstack.apache.org/api/apidocs-4.21/apis/updateVirtualMachine.html

I checked this and this is due to a bug in cloudstack-go SDK.

@kiranchavala I have created a fix in cloudstack-go SDK here: https://github.com/apache/cloudstack-go/pull/118 This PR will require a change in go mod to update cloudstack-go version after the above PR is merged.

vishesh92 avatar Sep 01 '25 07:09 vishesh92