Use interface for storage interactions in Appendonly TAM
This PR provides basic SMGR infrastructure for AO relations. This interface is needed for Yezzey support. Developed originally for Greenplum 6, adapted for Cloudberry.
fix #ISSUE_Number
Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
- [ ] Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
- [ ] Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
- [ ] Learn the coding contribution guide, including our code conventions, workflow and more.
- [ ] List your communication in the GitHub Issues or Discussions (if has or needed).
- [ ] Document changes.
- [ ] Add tests for the change
- [ ] Pass
make installcheck - [ ] Pass
make -C src/test installcheck-cbdb-parallel - [ ] Feel free to request
cloudberrydb/devteam for review and approval when your PR is ready🥳
This change is pure interface substitution, no other features/regression added. There are still some more patch needed to make Yezzey work fine with CBDB, but I considered to split there changes into separate work.
It is an interesting task to read and write files on S3 through the implementation of Appendonly table's smgr.
Thats exactly the point. And this is how Yezzey extension works for GP6.
Please resolve conflicts
Please resolve conflicts
Hi! Conflicts resolved !
Hi @my-ship-it It would be better to reapprove this PR because there have been code changes since your last approval.
Any updates?
@my-ship-it Hi! Can you provide any review on this PR please?