cloudberry icon indicating copy to clipboard operation
cloudberry copied to clipboard

Support distributed by clause specification when Create MV if not exists

Open reshke opened this issue 1 year ago • 4 comments

$subj

For some reason, current grammatical parser does not accept Distributed By clause in case IF NOT EXISTS specified for materialized view, which I don't any any reason to disallow

reshke avatar Aug 08 '24 13:08 reshke

hmmm icw-test are failing, but they look unrelated to C.M.V, aren't they?

reshke avatar Aug 08 '24 15:08 reshke

Hi, please provide cases to verify what you have done.

avamingli avatar Aug 08 '24 15:08 avamingli

Hi, please provide cases to verify what you have done.

Hi, you mean some regression test-cases? They are as obvious as

create table t1(i int);
create materialized view if not exists mv1 as select i from t1 distributed by (i);

(this fails on current HEAD)

I dont think we need anything more complicated here.

Will do

reshke avatar Aug 08 '24 16:08 reshke

Seems that matview_optimizer.out depends on matview tests. Pushed commit should fix test

reshke avatar Aug 09 '24 09:08 reshke

Are there any open items/suggestion/issues?

reshke avatar Aug 16 '24 10:08 reshke