cloudberry icon indicating copy to clipboard operation
cloudberry copied to clipboard

checkberry gpcheckperf series updates are used to solve the problem that cbdb 1.5.2 version gpcheckperf does not display disk information

Open August-beaulo opened this issue 1 year ago • 6 comments

fix https://github.com/cloudberrydb/cloudberrydb/issues/421 cbdb 1.5.2 version gpcheckperf does not display disk information


Change logs

  1. Changes to fix gpcheckperf failure with an exception when sometime time command output has a comma separator instead of a dot.

  2. Before this patch, while running gpcheckperf utility the buffer was set by default for the underlying gpnetbenchClient utility as 32Kb. It led to problem with receiving annoying and misleading warnings about connections between hosts. Use '--buffer-size' flag with size in kilobytes to set buffer size, which will be used at gpnetbenchClient. It is an optional parameter. The default value is 8Kb.

  3. Update gpcheckperf makefile README.md from greenplum 2 cbdb & add gpshrink & gpdemo based on the greenplum gpcheckperf command parameter and function call update.

etc.

Why are the changes needed?

The open source database gp has made a series of updates to the gpcheckperf tool, including

  1. Replace scp with rsync
  2. .Fixing gpcheckperf failure on -V with -f optio
  3. gpcheckperf: Fix memory calculation function
  4. gpcheckperf - Update a Python 3 reference of "python" to "python3"
  5. gpcheckperf: incorporating parity changes from 6X PR
  6. gpcheckperf: fixing string parsing in parseMultiDDResult()
  7. gpcheckperf: add buffer size parameter
  8. Fixing if the time command has comma in the output

Does this PR introduce any user-facing change?

no

How was this patch tested?

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • [ ] Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • [ ] Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • [ ] Learn the coding contribution guide, including our code conventions, workflow and more.
  • [ ] List your communication in the GitHub Issues or Discussions (if has or needed).
  • [ ] Document changes.
  • [ ] Add tests for the change
  • [ ] Pass make installcheck
  • [ ] Pass make -C src/test installcheck-cbdb-parallel
  • [ ] Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

August-beaulo avatar May 10 '24 04:05 August-beaulo

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 5 committers have signed the CLA.

:white_check_mark: August-beaulo
:x: Annu149
:x: piyushc01
:x: jnihal
:x: red1452
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar May 10 '24 04:05 CLAassistant

I recommend rebasing your code on the latest upstream/main as some of the commits made on May 10th appear to be weird.

tuhaihe avatar May 10 '24 05:05 tuhaihe

I recommend rebasing your code on the latest upstream/main as some of the commits made on May 10th appear to be weird.

After rebasing, the formats look good to me. Thanks.

tuhaihe avatar May 10 '24 08:05 tuhaihe

@August-beaulo Please don't change original commit, and add a new commit for your own logic.

my-ship-it avatar May 10 '24 08:05 my-ship-it

conflicts need to be resolved

avamingli avatar May 17 '24 02:05 avamingli

conflicts need to be resolved

conflicts resolved

August-beaulo avatar May 17 '24 07:05 August-beaulo