cloudberry icon indicating copy to clipboard operation
cloudberry copied to clipboard

change `MAX_TARABLE_SYMLINK_PATH_LENGTH` to 200

Open shmiwy opened this issue 2 years ago • 2 comments

Symlink targets currently have a length limit of 100, which may not be sufficient in many test cases, so we change it to 200 here.


Change logs

change MAX_TARABLE_SYMLINK_PATH_LENGTH to 200

Why are the changes needed?

In many test cases, we found that the 100 limit was not enough.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • [x] Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • [x] Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • [x] Learn the coding contribution guide, including our code conventions, workflow and more.
  • [x] List your communication in the GitHub Issues or Discussions (if has or needed).
  • [x] Document changes.
  • [x] Add tests for the change
  • [x] Pass make installcheck
  • [x] Pass make -C src/test installcheck-cbdb-parallel
  • [x] Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

shmiwy avatar Dec 28 '23 05:12 shmiwy

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 28 '23 05:12 CLAassistant

Please fix CI failures.

my-ship-it avatar Feb 18 '24 09:02 my-ship-it

@shmiwy Please fix CI failures?

my-ship-it avatar Jul 24 '24 01:07 my-ship-it

After discussion with @shmiwy, close the PR.

my-ship-it avatar Jul 26 '24 01:07 my-ship-it