cloudberry icon indicating copy to clipboard operation
cloudberry copied to clipboard

postgres_fdw: add missing test files and fix regression tests

Open roseduan opened this issue 6 months ago • 3 comments

Some essential files such as postgres_setup.bash and *_postgres_init.sql were missing, causing postgres_fdw regression tests to fail. These files existed in upstream GPDB. We restored them and fixed the tests so that all cases now pass.

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • [ ] Bug fix (non-breaking change)
  • [ ] New feature (non-breaking change)
  • [ ] Breaking change (fix or feature with breaking changes)
  • [ ] Documentation update

Breaking Changes

Test Plan

  • [ ] Unit tests added/updated
  • [ ] Integration tests added/updated
  • [ ] Passed make installcheck
  • [ ] Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


roseduan avatar Jun 25 '25 10:06 roseduan

Thanks for adding those tests back

my-ship-it avatar Jun 26 '25 01:06 my-ship-it

Add running tests to regular CI so that we can protect it?

my-ship-it avatar Jun 26 '25 05:06 my-ship-it

Add running tests to regular CI so that we can protect it?

Can we add postgres_fdw to our CI ? @edespino

roseduan avatar Jul 30 '25 09:07 roseduan