climate icon indicating copy to clipboard operation
climate copied to clipboard

Published 20 hours ago • verified publisher icon apache

CLIMATE - 803 Initial Stucture for Handling mask for non-maskedd arrays

Open prateekiiest opened this issue 6 years ago • 15 comments

As an initial structure I am only including checking the exception and will gradually work upon finding the masked array if the given data set array is not masked

prateekiiest avatar May 26 '18 08:05 prateekiiest

Can I see an example of a ndarray data set having missing values. By convention is the missing values represented as None or isnan ?

prateekiiest avatar May 26 '18 09:05 prateekiiest

@MichaelArthurAnderson your views?

I have mentioned in the climate issues

prateekiiest avatar May 30 '18 16:05 prateekiiest

Thank you @prateekiiest Over on Jira this issue was reported by @huikyole, he is on vacation right now but I am sure he can answer your question when he returns.

lewismc avatar Jun 04 '18 21:06 lewismc

@prateekiiest once we get an example of ndarray data set having missing values it would be great tp create a unit test for this.

lewismc avatar Jun 04 '18 21:06 lewismc

Thank you @lewismc for letting me know about it. I look forward to it.

prateekiiest avatar Jun 05 '18 02:06 prateekiiest

Tests seem to fail in case of dependencies netcdf4

prateekiiest avatar Jun 14 '18 08:06 prateekiiest

@prateekiiest do you mean it seems to fail? Can you elaborate?

lewismc avatar Jun 14 '18 17:06 lewismc

Oops, sorry I actually meant to say fail. Maybe slipped off.

Actually Travis test fails for py2.7 and py3.5

screenshot 135

May be some dependency issues?

I saw a PR recently related to netcdf4. https://github.com/apache/climate/pull/507

I am not sure if its related to that.

prateekiiest avatar Jun 15 '18 02:06 prateekiiest

@huikyole @agoodm can you guys please scope out this PR. Thanks, we are working on the build issues.

lewismc avatar Jun 26 '18 19:06 lewismc

Ah, I take it this is why you added cython to the dependencies list @lewismc ? conda has been having all sorts of issues with dependency trees lately, as recently @huikyole and I both discovered that pyyaml wasn't actually being included in RCMES distributions like it was supposed to be. We had to add that dependency explicitly to our builds even though we didn't need to before.

agoodm avatar Jun 26 '18 19:06 agoodm

Oh, and please close and reopen the PR @prateekiiest so we can see the build run again.

agoodm avatar Jun 26 '18 19:06 agoodm

ok, @agoodm

prateekiiest avatar Jun 27 '18 01:06 prateekiiest

@lewismc still fails for pydap as in the other PR #503

prateekiiest avatar Jun 27 '18 01:06 prateekiiest

Hi @prateekiiest please close and reopen again, I added netcdftime to the build profiles

lewismc avatar Jun 27 '18 04:06 lewismc

@huikyole could you please look into the present approach?

prateekiiest avatar Aug 15 '18 06:08 prateekiiest