celix icon indicating copy to clipboard operation
celix copied to clipboard

Unified Error Codes for libdfi

Open PengZheng opened this issue 1 year ago • 0 comments

Intro

Currently each component (by component we mean .h/.c pair, which is borrowed from Lakos' Large Scale C++) in libdfi has its own error code definition:

In dyn_function.c, we have:

static const int OK = 0;
static const int ERROR = 1;

In dyn_type.c, there is:

static const int OK = 0;
static const int ERROR = 1;
static const int MEM_ERROR = 2;
static const int PARSE_ERROR = 3;

Unified Error Codes

Given that celix_status_t now support a custom facility error part, I think the int return can be upgraded to a celix_status_t. And because celix_status_t is a typedef to int, this maybe is even backwards compatible.

But this would be nice as a future enhancement and port of this pull request.

Originally posted by @pnoltes in https://github.com/apache/celix/pull/699#discussion_r1471690851

PengZheng avatar Feb 02 '24 05:02 PengZheng