celix
celix copied to clipboard
Erroneous error handling in http admin
There are several issues in the http admin error handling:
- If
httpAdmin_createfinally fails here, an error code should be returned instead. - The above applies to
websocketAdmin_create. httpAdmin_createshould take the responsibility of releasinghttpRootin error condition, which is currently not done.- In
http_admin_stop, various resources is NOT released in reverse order as they are acquired.
Our new error injector may help testing this.
Originally posted by @PengZheng in https://github.com/apache/celix/pull/476#discussion_r1111598092