celix icon indicating copy to clipboard operation
celix copied to clipboard

Bugfix/data races

Open Oipo opened this issue 5 years ago • 7 comments

Fix some issues,

~~epoll_wait in pubsub is stuck~~

Oipo avatar May 28 '20 12:05 Oipo

Codecov Report

Merging #245 into master will decrease coverage by 0.02%. The diff coverage is 84.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   67.82%   67.80%   -0.03%     
==========================================
  Files         127      127              
  Lines       26375    26343      -32     
==========================================
- Hits        17890    17862      -28     
+ Misses       8485     8481       -4     
Impacted Files Coverage Δ
bundles/pubsub/pubsub_utils/src/pubsub_utils_url.c 52.15% <75.00%> (+0.40%) :arrow_up:
...b/pubsub_admin_tcp/src/pubsub_tcp_topic_receiver.c 62.70% <76.19%> (-0.42%) :arrow_down:
...e_services/topology_manager/src/topology_manager.c 85.34% <83.87%> (-0.70%) :arrow_down:
...s/pubsub/pubsub_admin_tcp/src/pubsub_tcp_handler.c 76.21% <85.07%> (+<0.01%) :arrow_up:
...dmin_websocket/src/pubsub_websocket_topic_sender.c 82.06% <85.71%> (-0.52%) :arrow_down:
bundles/logging/log_admin/src/celix_log_admin.c 99.73% <100.00%> (+<0.01%) :arrow_up:
...sub/pubsub_admin_tcp/src/pubsub_tcp_topic_sender.c 64.32% <100.00%> (+0.21%) :arrow_up:
...in_websocket/src/pubsub_websocket_topic_receiver.c 68.17% <100.00%> (+0.16%) :arrow_up:
libs/framework/src/framework.c 75.32% <100.00%> (+0.01%) :arrow_up:
libs/framework/src/service_registry.c 71.89% <100.00%> (+0.07%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0f2bb47...d3e4b18. Read the comment docs.

codecov-commenter avatar May 28 '20 13:05 codecov-commenter

Fix some issues,

epoll_wait in pubsub is stuck

is the "stuck" fixed in this or is this still an issue?

pnoltes avatar May 30 '20 12:05 pnoltes

It has been fixed (I think I forgot to unlock a mutex somewhere before...)

Oipo avatar May 30 '20 12:05 Oipo

This PR fixes some race conditions in the civetweb sources we are using.

First we have the civetweb sources at multiple location. IMO we should combine this to a static lib or CMake source object. I have makde a ticket for this #246

We should also bring these civetweb changes back to civetweb. But is a ticket with a ref to this PR enough?

pnoltes avatar May 30 '20 12:05 pnoltes

I've started a discussion about upstreaming at civetweb.

Oipo avatar May 30 '20 14:05 Oipo

getaddrinfo() apparently does something else on mac than on linux...

Oipo avatar Jun 08 '20 20:06 Oipo

@pnoltes While this branch has seen several approvals, I have this gut feeling that now is not an opportune time to merge this. There's been much activity to get our next release up to a good enough quality, so my proposal is to merge this for the release after the upcoming one. Gives us more room to fix the changes in this PR if things go awry.

Oipo avatar Jun 26 '20 08:06 Oipo