celeborn icon indicating copy to clipboard operation
celeborn copied to clipboard

[CELEBORN-1615] Start the http server after all handlers added

Open turboFei opened this issue 1 year ago • 2 comments

What changes were proposed in this pull request?

Start the http server after all handlers added.

Why are the changes needed?

Do not expose the RESTful server before all handlers initialized.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UT.

turboFei avatar Sep 25 '24 18:09 turboFei

After some digging, this PR might not find the root cause. The master class is a subclass of the Service class. The master object creates a master instance and calls its initialize method. 截屏2024-09-27 16 04 03 Master instance calls its superclass method of initialize. 截屏2024-09-27 16 04 44 HttpService calls its superclass method of initialize. 截屏2024-09-27 16 12 53 Initialize method in service. 截屏2024-09-27 16 05 27

Those initialization methods are invoked in the same thread.

We should find out the root cause and fix this problem.

FMX avatar Sep 27 '24 08:09 FMX

Hi @waitinfuture

I have changed the PR description and title.

Just start to expose the RESTful server after all handlers initialization finished.

turboFei avatar Oct 01 '24 21:10 turboFei