celeborn icon indicating copy to clipboard operation
celeborn copied to clipboard

[CELEBORN-1553] Using the request base url as swagger server

Open turboFei opened this issue 1 year ago • 2 comments

What changes were proposed in this pull request?

Using the request base url as swagger server.

Currently, if the http host is bound to local, the swagger server is not reachable. For example:

celeborn.master.http.host=0.0.0.0
celeborn.worker.http.host=0.0.0.0

Why are the changes needed?

image

Does this PR introduce any user-facing change?

No, just use the request base url as swagger server.

How was this patch tested?

Integration testing: image

image

turboFei avatar Aug 09 '24 00:08 turboFei

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 33.35%. Comparing base (ea6617c) to head (e4eddab). Report is 17 commits behind head on main.

Files Patch % Lines
...rver/common/http/api/CelebornOpenApiResource.scala 0.00% 3 Missing :warning:
...rg/apache/celeborn/server/common/HttpService.scala 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2674      +/-   ##
==========================================
- Coverage   39.83%   33.35%   -6.47%     
==========================================
  Files         239      310      +71     
  Lines       15026    18193    +3167     
  Branches     1362     1672     +310     
==========================================
+ Hits         5984     6067      +83     
- Misses       8711    11786    +3075     
- Partials      331      340       +9     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 09 '24 00:08 codecov[bot]

cc @pan3793

turboFei avatar Aug 10 '24 02:08 turboFei

also cc @cfmcgrady @SteNicholas

turboFei avatar Aug 19 '24 05:08 turboFei

Hi @RexXiong

If no more comments, can we merge it? thanks

turboFei avatar Aug 31 '24 02:08 turboFei

Hi @RexXiong

If no more comments, can we merge it? thanks

Thanks for the reminder. Merge to main(v0.6.0)

RexXiong avatar Sep 03 '24 14:09 RexXiong