celeborn icon indicating copy to clipboard operation
celeborn copied to clipboard
verified publisher icon apache

[CELEBORN-1532][HELM] Make helm charts more customizable

Open ChenYi015 opened this issue 1 year ago • 3 comments

What changes were proposed in this pull request?

  • Add image.registry and rename imagePullSecrets to image.pullSecrets
  • Rename masterReplicas/workerReplicas to master.replicas/worker.replicas
  • Add master.labels/worker.labels
  • Rename podAnnotations to master.annotations/worker.annotations
  • Rename nodeSelector to master.nodeSelector/worker.nodeSelector
  • Rename affinity.master/affinity.worker to master.affinity/worker.affinity
  • Rename tolerations to master.tolerations/worker.tolerations
  • Rename environments to master.env/worker.env
  • Add master.envFrom/worker.envFrom
  • Rename priorityClass.master/priorityClass.worker to master.priorityClass/worker.priorityClass
  • Rename resources.master/resources.worker to master.resources/worker.resources
  • Rename dnsPolicy to master.dnsPolicy/worker.dnsPolicy
  • Rename hostNetwork to master.hostNetwork/worker.hostNetwork
  • Rename service to master.service/worker.service
  • Rename podMonitor to master.podMonitor/worker.podMonitor
  • Rename securityContext to master.podSecurityContext/worker.podSecurityContext
  • Add master.securityContext/worker.securityContext

Why are the changes needed?

  • Make the Celeborn Helm charts more customizable and improve the maintenance.
  • Unified the various configurations, all master/worker related configurations are prefixed with master/worker.

Does this PR introduce any user-facing change?

Yes.

How was this patch tested?

Locally test.

ChenYi015 avatar Jul 31 '24 11:07 ChenYi015

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Aug 21 '24 08:08 github-actions[bot]

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Sep 19 '24 08:09 github-actions[bot]

@ChenYi015 Can you split this PR into several small PRs? Changing one feature in one PR can be easier for reviewers.

FMX avatar Sep 24 '24 08:09 FMX

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Oct 15 '24 08:10 github-actions[bot]

This issue was closed because it has been staled for 10 days with no activity.

github-actions[bot] avatar Oct 26 '24 08:10 github-actions[bot]

Hi @ChenYi015 , any updates for this PR?

nqvuong1998 avatar Mar 28 '25 04:03 nqvuong1998

Sorry for the late response. I will split this PR into several smaller ones.

ChenYi015 avatar Mar 28 '25 06:03 ChenYi015