celeborn icon indicating copy to clipboard operation
celeborn copied to clipboard

[CELEBORN-1233] Add unit test to verify data correctness

Open jiang13021 opened this issue 1 year ago • 2 comments

What changes were proposed in this pull request?

Add a unit test for https://github.com/apache/celeborn/pull/2235

Why are the changes needed?

ditto

Does this PR introduce any user-facing change?

No

How was this patch tested?

org.apache.celeborn.tests.spark.CelebornWorkerRestartSuite

jiang13021 avatar Jul 19 '24 05:07 jiang13021

ping @waitinfuture @RexXiong Please take a look. Thanks.

jiang13021 avatar Jul 30 '24 02:07 jiang13021

ping @waitinfuture @RexXiong Please take a look. Thanks.

see comments at https://github.com/apache/celeborn/pull/2609

RexXiong avatar Jul 31 '24 06:07 RexXiong

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Aug 20 '24 08:08 github-actions[bot]

ping @waitinfuture @RexXiong Please take a look. Thanks.

see comments at #2609

Hi, we found that without CELEBORN-1233's PR: #2235 , if a file is deleted, the worker won't throw an exception and this could lead to data correctness issues. There is no unit test for CELEBORN-1233, so I have written one. However, it is not a unit test for #2609.

jiang13021 avatar Aug 27 '24 03:08 jiang13021

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Sep 16 '24 08:09 github-actions[bot]

This issue was closed because it has been staled for 10 days with no activity.

github-actions[bot] avatar Sep 26 '24 08:09 github-actions[bot]