celeborn icon indicating copy to clipboard operation
celeborn copied to clipboard

[CELEBORN-1340] Congestion control slow start logic should make all interval can be customized and make it smaller

Open AngersZhuuuu opened this issue 11 months ago • 3 comments

What changes were proposed in this pull request?

In this pr we do two things:

  1. Current sleep time is too long for small task, will cause task delay so long, some small task from 30m to 2h
  2. Make all interval can be customized

Why are the changes needed?

Fix performance issue and make it can be customized

Does this PR introduce any user-facing change?

How was this patch tested?

AngersZhuuuu avatar Mar 19 '24 09:03 AngersZhuuuu

ping @onebox-li @waitinfuture

AngersZhuuuu avatar Mar 19 '24 09:03 AngersZhuuuu

Codecov Report

Attention: Patch coverage is 96.55172% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 48.92%. Comparing base (ab252c2) to head (bfaba09). Report is 83 commits behind head on main.

:exclamation: Current head bfaba09 differs from pull request most recent head fc5e325. Consider uploading reports for the commit fc5e325 to get more accurate results

Files Patch % Lines
...e/celeborn/common/write/SlowStartPushStrategy.java 87.50% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2404      +/-   ##
==========================================
+ Coverage   48.85%   48.92%   +0.08%     
==========================================
  Files         209      209              
  Lines       13101    13120      +19     
  Branches     1134     1134              
==========================================
+ Hits         6399     6418      +19     
  Misses       6282     6282              
  Partials      420      420              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 19 '24 10:03 codecov[bot]

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar May 15 '24 08:05 github-actions[bot]

This issue was closed because it has been staled for 10 days with no activity.

github-actions[bot] avatar May 26 '24 08:05 github-actions[bot]