cassandra icon indicating copy to clipboard operation
cassandra copied to clipboard

Published 20 hours ago • verified publisher icon apache

CASSANDRA-17753: Include GitSHA in nodetool version output

Open aratno opened this issue 2 years ago • 10 comments

Jira: https://issues.apache.org/jira/browse/CASSANDRA-17753 CircleCI: https://app.circleci.com/pipelines/github/aratno/cassandra?branch=CASSANDRA-17753-nodetool-version-gitsha

# When Cassandra is built with a clean Git index
$ ./bin/nodetool version
ReleaseVersion: 4.1-alpha2-SNAPSHOT
GitSHA: 5fce07e2f1e2e0b9cf7d82adfd8c0b21993f8672

# When Cassandra is built with a dirty Git index
$ ./bin/nodetool version
ReleaseVersion: 4.1-alpha2-SNAPSHOT
GitSHA: 5fce07e2f1e2e0b9cf7d82adfd8c0b21993f8672-dirty

aratno avatar Jul 13 '22 22:07 aratno

suggestions/requests raised in the ticket

michaelsembwever avatar Jul 14 '22 05:07 michaelsembwever

Thanks @michaelsembwever - all changes requested are now addressed. Do you want me to merge in trunk and resolve conflicts, squash, or anything else to make this easier to commit?

aratno avatar Jul 17 '22 18:07 aratno

Yes, please squash to one commit. Are you familiar with our commit message format? (if not, the committer will adjust it accordingly)

There's also one minor edit to make, the CHANGES.txt line need to finish with (CASSANDRA-17753)

michaelsembwever avatar Jul 17 '22 21:07 michaelsembwever

Should be all good now - did I do it right @michaelsembwever?

aratno avatar Jul 18 '22 03:07 aratno

ci-cassandra: https://ci-cassandra.apache.org/job/Cassandra-devbranch-artifacts/1749/

LGTM 👍

michaelsembwever avatar Jul 19 '22 11:07 michaelsembwever

latest changed LGTM! thanks!

https://ci-cassandra.apache.org/job/Cassandra-devbranch/1886/

michaelsembwever avatar Aug 20 '22 07:08 michaelsembwever

https://ci-cassandra.apache.org/job/Cassandra-devbranch/1886/

something is up with the dtest-upgrade… (took a re-run of it here too: https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest-upgrade/1177/ ) haven't had time to investigate it… but wondering if this patch needs to be rebased off latest trunk…

michaelsembwever avatar Aug 21 '22 18:08 michaelsembwever

Just rebased, looks like the Paxos state issue impacting test clean-up across the board.

Unexpected error found in node logs (see stdout for full details). Errors: [[node1] 'ERROR [main] 2022-08-20 10:40:54,861 CassandraDaemon.java:896 - Exception encountered during startup\njava.lang.ExceptionInInitializerError: null\n\tat org.apache.cassandra.service.paxos.PaxosState.initializeTrackers(PaxosState.java:116)

aratno avatar Aug 23 '22 04:08 aratno

new round: https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/1900/pipeline

michaelsembwever avatar Aug 29 '22 13:08 michaelsembwever

Another CircleCI run: https://app.circleci.com/pipelines/github/aratno/cassandra?status=none&status=running&branch=CASSANDRA-17753-nodetool-version-gitsha

aratno avatar Sep 06 '22 18:09 aratno