cassandra icon indicating copy to clipboard operation
cassandra copied to clipboard

CASSANDRA-17677: Fix BulkLoader to load entireSSTableThrottle and entireSSTableInterDcThrottle

Open frankgh opened this issue 2 years ago • 1 comments

entire_sstable_stream_throughput_outbound and entire_sstable_inter_dc_stream_throughput_outbound were introduced in CASSANDRA-17065. They were added to the LoaderOptions class but they are not being used in the BulkLoader class. In this commit, we make use of the entire_sstable streaming options in BulkLoader. In addittion, the throttle and interDcThrottle are being passed as MB/s but they should be MiB/s. This commit fixes the verbiage as well as setting the correct value for those properties in BulkLoader.

frankgh avatar Jun 22 '22 19:06 frankgh

Thanks for the review @ekaterinadimitrova2 and @yifan-c . I think this PR is in a good place for merging.

frankgh avatar Jul 06 '22 23:07 frankgh