carbondata icon indicating copy to clipboard operation
carbondata copied to clipboard

[CARBONDATA-4058] create or insert data into the carbon table through …

Open liyong072 opened this issue 3 years ago • 10 comments

…Hive throw NPE

Why is this PR needed?

If the tableprops(in file org/apache/carbondata/hive/CarbonHiveMetastoreListener.scala) does not have org.apache.spark.sql.CarbonSource property, it will throw NPE.

What changes were proposed in this PR?

Changed case ALTER_TABLE in CarbonHiveMetastoreListener. Added a property check(org.apache.spark.sql.CarbonSource) in tableprops

Does this PR introduce any user interface change?

  • No

Is any new testcase added?

  • No

liyong072 avatar Dec 15 '20 10:12 liyong072

Can one of the admins verify this patch?

CarbonDataQA2 avatar Dec 15 '20 10:12 CarbonDataQA2

Add to whitelist

ajantha-bhat avatar Dec 15 '20 14:12 ajantha-bhat

Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5171/

CarbonDataQA2 avatar Dec 15 '20 15:12 CarbonDataQA2

Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3409/

CarbonDataQA2 avatar Dec 15 '20 15:12 CarbonDataQA2

@liyong072 : Can you please add a testcase that cause the issue in this PR?

ajantha-bhat avatar Dec 16 '20 04:12 ajantha-bhat

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3292/

CarbonDataQA2 avatar Dec 18 '20 10:12 CarbonDataQA2

Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5056/

CarbonDataQA2 avatar Jan 25 '21 05:01 CarbonDataQA2

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3298/

CarbonDataQA2 avatar Jan 25 '21 05:01 CarbonDataQA2

Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3297/

CarbonDataQA2 avatar Mar 10 '21 10:03 CarbonDataQA2

Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5055/

CarbonDataQA2 avatar Mar 10 '21 10:03 CarbonDataQA2