carbondata
carbondata copied to clipboard
apache
[CARBONDATA-4045] Add TPCDS TestCase for Spark on CarbonData Integration Test
Why is this PR needed?
There is no TPC-DS TestCases in the current source code. It is difficult to debug TPC-DS on small dataset. Also, TPC-DS TestCase would help to find possible issues
What changes were proposed in this PR?
- Add small dataset of TPCDS
- Add SQL of TPCDS
- Add 54 Testcases (There are 99 testcases in TPCDS, but only 54 testcases can run without empty result)
Does this PR introduce any user interface change?
- No
Is any new testcase added?
- Yes
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2920/
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4677/
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2921/
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4678/
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2923/
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4680/
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4681/
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2924/
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2927/
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4684/
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4690/
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2933/
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4693/
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2936/
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4697/
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2940/
@marchpure : The reason why we don't have TPCH and TPCDS in UT is we need a huge data set, loading huge data takes time.
What is the reason behind adding this? we can anyways have separate TPCH or TPCDS machines that can have automation script to give performance benchmark on every release
Also no need to run TPCH and TPCDS on every PR builder. Running once per release is enough.
@QiangCai , @kunal642 : What's your opinion on this?
@marchpure : The reason why we don't have TPCH and TPCDS in UT is we need a huge data set, loading huge data takes time.
What is the reason behind adding this? we can anyways have separate TPCH or TPCDS machines that can have automation script to give performance benchmark on every release
Also no need to run TPCH and TPCDS on every PR builder. Running once per release is enough.
@QiangCai , @kunal642 : What's your opinion on this?
- The TPCDS dataset in this PR is really small(totally 33KB). it won"t took so much time to load and query. It may help to avoid possible issues with accepted overhead.
- it also help us to debug tpcds. explain plan ～analyse in local environment.
the inspiration to add tpcds test case is CARBONDATA 4008. Whose issue is Spark on CarbonData will fail in TPCDS Query 83. This issue seems has been there for a log time, which implies that our UT is not enough. I believe that we can add a profile to turn on/off of TPCDS test in the future if the automatic TPCDS machine is ready.
Maybe we can have a module name 'carbondata-integretion-test'?