carbondata icon indicating copy to clipboard operation
carbondata copied to clipboard

Published 20 hours ago • verified publisher icon apache

[CARBONDATA-1360] fix for update table failures for struct data type

Open ashwini-krishnakumar opened this issue 7 years ago • 40 comments

Problem: updates not working for complex data type struct. escape characters used for internal delimiters was causing the update failures and null updates . Fix : escape characters used for internal delimiters was causing the update failures and null updates to fix this escape characters are replaced before update processing.

Be sure to do all of the following to help us incorporate your contribution quickly and easily:

  • [ ] Make sure the PR title is formatted like: [CARBONDATA-<Jira issue #>] Description of pull request

  • [ ] Make sure tests pass via mvn clean verify. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes).

  • [ ] Replace <Jira issue #> in the title with the actual Jira issue number, if there is one.

  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

  • [ ] Testing done

     Please provide details on 
 - Whether new unit test cases have been added or why no new tests are required?
 - What manual testing you have done?
 - Any additional information to help reviewers in testing this change.

  • [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

ashwini-krishnakumar avatar Sep 27 '17 13:09 ashwini-krishnakumar

Can one of the admins verify this patch?

CarbonDataQA avatar Sep 27 '17 13:09 CarbonDataQA

Can one of the admins verify this patch?

ravipesala avatar Sep 27 '17 13:09 ravipesala

Can one of the admins verify this patch?

CarbonDataQA avatar Sep 27 '17 13:09 CarbonDataQA

retest this please

jackylk avatar Oct 20 '17 00:10 jackylk

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/511/

CarbonDataQA avatar Oct 20 '17 01:10 CarbonDataQA

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1140/

ravipesala avatar Oct 20 '17 03:10 ravipesala

Problem: updates not working for complex data type . Fix : escaspe characters used for internal demiliters was causing the update failures and null updates to fix this escaspe characters are replaced before update processing. Changes :1. added testcase to test update on complex struct data type with two level delimiters 2. fixed update failures for array and struct datatype 3. added testcase for update with array data type

ashwini-krishnakumar avatar Oct 23 '17 13:10 ashwini-krishnakumar

Can one of the admins verify this patch?

ravipesala avatar Oct 23 '17 13:10 ravipesala

pleas note - This PR has a dependency of PR 1101 to be merged first .

ashwini-krishnakumar avatar Oct 23 '17 13:10 ashwini-krishnakumar

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1286/

ravipesala avatar Oct 24 '17 00:10 ravipesala

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1420/

CarbonDataQA avatar Nov 24 '17 12:11 CarbonDataQA

retest this please

ashwini-krishnakumar avatar Feb 10 '18 13:02 ashwini-krishnakumar

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3673/

CarbonDataQA avatar Feb 10 '18 13:02 CarbonDataQA

Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2433/

CarbonDataQA avatar Feb 10 '18 14:02 CarbonDataQA

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3506/

ravipesala avatar Feb 10 '18 16:02 ravipesala

@ashwini-krishnakumar I met the same problem and raised a pr to fix this issue, please help to review PR#1962

zzcclp avatar Feb 11 '18 06:02 zzcclp

retest this please

ashwini-krishnakumar avatar Feb 12 '18 08:02 ashwini-krishnakumar

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3715/

CarbonDataQA avatar Feb 12 '18 08:02 CarbonDataQA

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2475/

CarbonDataQA avatar Feb 12 '18 09:02 CarbonDataQA

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3517/

ravipesala avatar Feb 12 '18 10:02 ravipesala

@ashwini-krishnakumar I run your test cases with my pr and all are passed too.

zzcclp avatar Feb 13 '18 06:02 zzcclp

@ashwini-krishnakumar PR#1962 has been merged, I think it don't need to change CarbonScalaUtil.scala and just remain the test case.

zzcclp avatar Feb 26 '18 02:02 zzcclp

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3067/

CarbonDataQA avatar Mar 14 '18 18:03 CarbonDataQA

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4311/

CarbonDataQA avatar Mar 14 '18 20:03 CarbonDataQA

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5199/

CarbonDataQA avatar Apr 19 '18 23:04 CarbonDataQA

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3989/

CarbonDataQA avatar Apr 20 '18 00:04 CarbonDataQA

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7136/

CarbonDataQA avatar Jul 14 '18 04:07 CarbonDataQA

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5912/

CarbonDataQA avatar Jul 14 '18 08:07 CarbonDataQA

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/63/

CarbonDataQA avatar Sep 05 '18 16:09 CarbonDataQA

Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8812/

CarbonDataQA avatar Sep 26 '18 19:09 CarbonDataQA