camel
camel copied to clipboard
[Camel 18327] updated updateTaskState resume logic to seek from the point that was last committed
:warning: This PR changes Camel components and will be tested automatically.
Hi, thanks for your contribution. There's a compilation failure:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project camel-kafka: Compilation failure
[ERROR] /home/runner/work/camel/camel/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaFetchRecords.java:[430,29] error: unclosed string literal
[ERROR] -> [Help 1]
:x: Finished component verification: 1 component(s) test failed out of 1 component(s) tested
:x: Finished component verification: 1 component(s) test failed out of 1 component(s) tested
:x: Finished component verification: 1 component(s) test failed out of 1 component(s) tested
Attaching the last logs for your debugging. The problem seems to be caused by checkstyle failures. You can fix and verify those by running the following command:
mvn -Pformat,fastinstall clean install && mvn -Psourcecheck
:x: Finished component verification: 1 component(s) test failed out of 1 component(s) tested
:x: Finished component verification: 1 component(s) test failed out of 1 component(s) tested
I keep getting the below error when I try to build locally: Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion failed with message: Detected Maven Version: 3.3.9 is not in the allowed range 3.5.0.
Use a newer maven version. I'm able to build with an old 3.6.3 version, my suggestion is using the latest >3.8
Thanks for the PR.
The implementation is looking promising, but there are some style and compilation issues. They need to be fixed so the automated tests can run.
resolved
:x: Finished component verification: 1 component(s) test failed out of 1 component(s) tested
❌ Finished component verification: 1 component(s) test failed out of 1 component(s) tested
Current failures are caused by checkstyle issue (which is preventing the test execution). I attached the logs for your analysis and fix.
:x: Finished component verification: 1 component(s) test failed out of 1 component(s) tested
I am not sure what is failing, the builds and test are successful when I run them locally. Also, I ran below command as well: mvn -Pformat,fastinstall clean install && mvn -Psourcecheck
One additional note, is that the code is currently out of sync with main and cannot be merged:
"This branch cannot be rebased due to conflicts"
To solve that you need to rebase the code with the current changes on main. Something like this would work:
git checkout main
git pull --rebase upstream main
git checkout CAMEL-18327-Kafka_consumer_closes_when_it_is_paused
git rebase main
This would put your work branch CAMEL-18327-Kafka_consumer_closes_when_it_is_paused in sync with the latest changes from main.
Obs.: please note that the name of the remote may be different on your system. You can check that with git remote -v.
rebased and format changes reverted
Thanks @geekrupam, but the branch is still in conflict and github won't allow us to merge. I think at some point there may have been a merge commit involved (if you look at the list of changes on the commit page here, you'll see it is listing 472 commits).
:heavy_check_mark: Finished component verification: 0 component(s) test failed out of 1 component(s) tested
I created a new branch with another poll request
Closing. The other PR was merged. Thanks for your contribution @geekrupam