camel icon indicating copy to clipboard operation
camel copied to clipboard

CAMEL-18376: camel-pulsar: add redelivery backoff for ack timeout, nack

Open anthonywu-toast opened this issue 3 years ago • 4 comments

Resolves the following Jira issue: https://issues.apache.org/jira/browse/CAMEL-18376

This PR adds in the ability to add a RedeliveryBackoff for both the ack timeout and negative acknowledgement cases (details linked). Modifications to existing tests and the addition of a new test should ensure that the backoff works as expected.

Checklist:

  • [x] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [x] Each commit in the pull request should have a meaningful subject line and body.
  • [x] If you're unsure, you can format the pull request title like [CAMEL-XXX] Fixes bug in camel-file component, where you replace CAMEL-XXX with the appropriate JIRA issue.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Run mvn clean install -Psourcecheck in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically. Below are the contribution guidelines: https://github.com/apache/camel/blob/main/CONTRIBUTING.md

anthonywu-toast avatar Aug 10 '22 20:08 anthonywu-toast

:warning: This PR changes Camel components and will be tested automatically.

github-actions[bot] avatar Aug 10 '22 20:08 github-actions[bot]

:x: Finished component verification: 1 component(s) test failed out of 1 component(s) tested

github-actions[bot] avatar Aug 11 '22 05:08 github-actions[bot]

Will take a peek at job failures and fix shortly.

anthonywu-toast avatar Aug 11 '22 08:08 anthonywu-toast

:x: Finished component verification: 1 component(s) test failed out of 5 component(s) tested

github-actions[bot] avatar Aug 11 '22 10:08 github-actions[bot]

If there's another test failure, do you mind attaching the logs (or showing me where I can find them), @orpiske? My local machine seems to have trouble running these Docker-based tests.

anthonywu-toast avatar Aug 11 '22 12:08 anthonywu-toast

:x: Finished component verification: 1 component(s) test failed out of 5 component(s) tested

github-actions[bot] avatar Aug 11 '22 13:08 github-actions[bot]

If there's another test failure, do you mind attaching the logs (or showing me where I can find them), @orpiske? My local machine seems to have trouble running these Docker-based tests.

Access to the test logs is restricted by the organization, but I can upload them here as needed. test-logs(1).zip

orpiske avatar Aug 11 '22 13:08 orpiske

:x: Finished component verification: 1 component(s) test failed out of 5 component(s) tested

github-actions[bot] avatar Aug 11 '22 19:08 github-actions[bot]

:x: Finished component verification: 1 component(s) test failed out of 5 component(s) tested

github-actions[bot] avatar Aug 12 '22 05:08 github-actions[bot]

@orpiske mind if I get logs for the last failed run?

anthonywu-toast avatar Aug 12 '22 09:08 anthonywu-toast

@orpiske mind if I get logs for the last failed run?

test-logs.zip

orpiske avatar Aug 12 '22 11:08 orpiske

:x: Finished component verification: 1 component(s) test failed out of 5 component(s) tested

github-actions[bot] avatar Aug 12 '22 15:08 github-actions[bot]

Thanks for sending the files; I managed to commandeer a coworker's laptop running on x86_64 to avoid the local issues I was seeing (since I'm on an M1 it revolves around https://github.com/apache/pulsar/issues/12944). I left configuring container startup/timeouts, etc. out of the loop for now. Tests pass locally so hopefully this should be the last commit!

anthonywu-toast avatar Aug 12 '22 20:08 anthonywu-toast

:heavy_check_mark: Finished component verification: 0 component(s) test failed out of 5 component(s) tested

github-actions[bot] avatar Aug 13 '22 08:08 github-actions[bot]

Yeah it works now, thanks for contributing to Camel. You are welcome to keep improving ;)

davsclaus avatar Aug 13 '22 08:08 davsclaus