camel icon indicating copy to clipboard operation
camel copied to clipboard

Adds Camel Flowable component

Open tijsrademakers opened this issue 1 year ago • 10 comments

Description

This adds a new Camel component to send and receive messages / events from Flowable (https://flowable.org and https://github.com/flowable/flowable-engine). Flowable is an open source BPM project that had a Camel integration since the beginning of the project 7 years back. This contributes the Flowable Camel component to the Camel project to make it easier for Camel users to make use of the Flowable integration.

Target

  • [ x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • [ x] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

There is no issue yet, let me know if I should create it (if I can).

Apache Camel coding standards and style

  • [ x] I checked that each commit in the pull request has a meaningful subject line and body.
  • [ x] I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

tijsrademakers avatar Oct 10 '24 08:10 tijsrademakers

:star2: Thank you for your contribution to the Apache Camel project! :star2:

:robot: CI automation will test this PR automatically.

:camel: Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • :warning: Be careful when sharing logs. Review their contents before sharing them publicly.

github-actions[bot] avatar Oct 10 '24 08:10 github-actions[bot]

this code needs more review and updates to a Camel v4 style.

Does flowable require spring or what is the requirement for using spring / camel-spring ?

davsclaus avatar Oct 10 '24 13:10 davsclaus

Hi Claus, thanks for checking the PR. Flowable doesn't 100% require Spring but it's the easiest way to configure and use it. Let me know what should be changed for a Camel v4 style.

tijsrademakers avatar Oct 10 '24 13:10 tijsrademakers

Well it needs to be decoupled from spring and be able to run independent and configured more standard Camel, like all other components.

Camel today runs in pure camel (and with jbang) and as well on Spring Boot or Quarkus. And components need to work all places.

davsclaus avatar Oct 10 '24 15:10 davsclaus

And then the component need to be marked up with camel specific andantinos to make it document and tooling friendly - which also makes it useable with java fluent builder (endpoint-dsl).

davsclaus avatar Oct 10 '24 15:10 davsclaus

Hi, the PR has been updated to fully remove the dependency to Spring.

tijsrademakers avatar Oct 11 '24 14:10 tijsrademakers

can you rebase

davsclaus avatar Oct 14 '24 09:10 davsclaus

Can you rebase this tomorrow morning - then we likely have some time to look more into this PR

davsclaus avatar Oct 15 '24 12:10 davsclaus

Updated the PR with the latest state from Camel main

tijsrademakers avatar Oct 16 '24 07:10 tijsrademakers

can you rebase

davsclaus avatar Oct 19 '24 15:10 davsclaus

can you rebase

davsclaus avatar Oct 23 '24 08:10 davsclaus

done

tijsrademakers avatar Oct 23 '24 09:10 tijsrademakers

I have manual merged this PR with some polished work. Closing this PR

davsclaus avatar Oct 27 '24 16:10 davsclaus