camel icon indicating copy to clipboard operation
camel copied to clipboard

(chores) camel-file: code cleanup

Open orpiske opened this issue 1 year ago • 3 comments

  • break large and complex methods

orpiske avatar May 10 '24 10:05 orpiske

:star2: Thank you for your contribution to the Apache Camel project! :star2:

:robot: CI automation will test this PR automatically.

:camel: Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • :warning: Be careful when sharing logs. Review their contents before sharing them publicly.

github-actions[bot] avatar May 10 '24 10:05 github-actions[bot]

have you tested camel-ftp, and camel-jsch that extends camel-file

davsclaus avatar May 10 '24 12:05 davsclaus

have you tested camel-ftp, and camel-jsch that extends camel-file

Yes. All of these changes go through multiple full builds on my own CI (i.e.: this change was done 2 days ago and have been under test a couple of times - last CI build, the 5th, is still in progress though)

orpiske avatar May 10 '24 13:05 orpiske

Looking fine on my own CI. Let's merge and see how it goes on ASF one.

orpiske avatar May 12 '24 06:05 orpiske