camel icon indicating copy to clipboard operation
camel copied to clipboard

Handle quote escape in bindy

Open Croway opened this issue 1 year ago • 1 comments

Description

Target

  • [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • [ ] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • [ ] I checked that each commit in the pull request has a meaningful subject line and body.
  • [ ] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

Croway avatar Feb 22 '24 13:02 Croway

:star2: Thank you for your contribution to the Apache Camel project! :star2:

:robot: CI automation will test this PR automatically.

:camel: Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • :warning: Be careful when sharing logs. Review their contents before sharing them publicly.

github-actions[bot] avatar Feb 22 '24 13:02 github-actions[bot]

Nice magic with the scanner.

We have StringQuoteHelper for safe splitting when using quotes as double or single quote chars. But I guess the scanner and bindy can in theory use other quote chars - but who would not use " ?

davsclaus avatar Feb 25 '24 08:02 davsclaus

is there more work needed for this PR or can it be ready for review and merge ?

davsclaus avatar Feb 27 '24 09:02 davsclaus

I'll come up with more tests, but can be merged at the moment

Croway avatar Feb 27 '24 11:02 Croway

If we need to backport this, then its good to have a JIRA ticket for this to track this

davsclaus avatar Feb 28 '24 05:02 davsclaus