camel-quarkus icon indicating copy to clipboard operation
camel-quarkus copied to clipboard

small syntax error

Open lucamaf opened this issue 3 years ago • 4 comments
trafficstars

lucamaf avatar Aug 05 '22 13:08 lucamaf

actually didn't know about camel-quarkus-xml-jaxp, so let's use that

On Fri, Aug 5, 2022 at 4:41 PM Peter Palaga @.***> wrote:

@.**** commented on this pull request.

Thanks for taking care, @lucamaf https://github.com/lucamaf.

Indeed, camel-quarkus-jaxp does not exist anymore, but I'd say the right suggestion should be camel-quarkus-xml-jaxp rather than camel-quarkus-jaxb .

Could you please explain why do you think it should be camel-quarkus-jaxb?

— Reply to this email directly, view it on GitHub https://github.com/apache/camel-quarkus/pull/3962#pullrequestreview-1063466347, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANFTIZWCS2S6Y6RWE2RUADVXURYRANCNFSM55WFVHDQ . You are receiving this because you were mentioned.Message ID: @.***>

--

LUCA MATTIA FERRARI

EMEA SENIOR EDGE SOLUTION ARCHITECT, ITILV3

Red Hat Spain https://www.redhat.com/

travessera de Gracia, 11

08021, Barcelona

@.*** M: +34-653-225-181 http://redhatemailsignature-marketing.itos.redhat.com/ https://red.ht/sig

lucamaf avatar Aug 05 '22 15:08 lucamaf

There are a few other places where we should also update this:

https://github.com/apache/camel-quarkus/search?q=camel-quarkus-jaxp

jamesnetherton avatar Aug 08 '22 06:08 jamesnetherton

I think the file is generated and we need to change in https://github.com/apache/camel-quarkus/blob/main/extensions/jms/runtime/src/main/doc/usage.adoc

zhfeng avatar Aug 08 '22 06:08 zhfeng

@lucamaf Do you still have time to work on this ? I think it's just a matter of targetting the main branch, changing to camel-quarkus-xml-jaxp and running mvn clean install -DskipTests ro regenerate the documentation.

Other occurences might be treated in other PRs.

Let us know if you don't have time.

aldettinger avatar Oct 13 '22 11:10 aldettinger

Let's close in favor of #4229

aldettinger avatar Oct 31 '22 16:10 aldettinger