Test aws-secrets-manager extension with Localstack #3741

[JiriOndrusek]

fixes https://github.com/apache/camel-quarkus/issues/3741

This is not a complete coverage of the aws-secrets-manager component:

• Test for operation replicateSecretToRegions is commented, because it causes internal error on localStack (it might be caused by missing configuration - needs to be investigated)
• class SecretsManagerPropertiesFunction is not covered. As you can see here, aws client is configured from properties and url_override is not there. It has to be investigated how to cover this functionality.

I changed quarkus/test/support/aws2/Aws2TestEnvContext.java] to support secrets-manager, but it means that it supports aws- (not aws2-..) component. I think that better approach would be to rename module to support/aws/ or create a new module for aws(not 2). On the other hand it would be a bigger change because a few lines of the code.

I'm keeping this PR as draft and would like to ask, whether I should:

1. Create separated module for support-aws(not 2)
2. Rename current suuport/aws2/ to support/aws/
3. Keep changes as it is

Before I mark this draft as prepared to merge, I'll create tickets for missing parts of the test coverage.

[jamesnetherton]

but it means that it supports aws- (not aws2-..) component

Could we not deal with this in AwsSecretsManagerTestEnvCustomizer? And do the property renaming in there (I.e remove old put new)?

[JiriOndrusek]

The follow-up ticket is https://github.com/apache/camel-quarkus/issues/3848

[zbendhiba]

Hello @JiriOndrusek. What are the pending tasks for this PR? Are there any responses for these questions mentioned in your PR message

1. Create separated module for support-aws(not 2)
2. Rename current suuport/aws2/ to support/aws/
3. Keep changes as it is

[JiriOndrusek]

@zbendhiba This PR is prepared to be merged. James suggested to move part of the code to a different location, which renders my question obsolete. I already switched from draft to ready for merge and i created a ticket with follow-up work - https://github.com/apache/camel-quarkus/issues/3848

[JiriOndrusek]

There might be problem with the failing CDI tests, I will look at it in the next days. (the change of the common part of aws-test-support seems like it shouldn't cause this error, but I'll verify it)

[zbendhiba]

@zbendhiba This PR is prepared to be merged. James suggested to move part of the code to a different location, which renders my question obsolete. I already switched from draft to ready for merge and i created a ticket with follow-up work - #3848

thanks