camel-k icon indicating copy to clipboard operation
camel-k copied to clipboard

(#5522) Enhance environment trait to include values from secrets/conf…

Open tdiesler opened this issue 1 year ago • 4 comments

tdiesler avatar Jun 14 '24 11:06 tdiesler

:warning: Unit test coverage report - coverage decreased from 39.9% to 39.8% (-0.1%)

github-actions[bot] avatar Jun 14 '24 12:06 github-actions[bot]

Thanks for the work. However, I think this is going too deep in introspecting the value provided by the user. The operator should not peek at any config or secret for a matter of sensitive data. In fact, the goal of the feature is to let the user only provide the configuration and the goal of the operator should be syntactic sugar, transforming the trait parameter into the env container format. We should not worry if the user has provided a missing value, this should be an error that the rest of kubernetes logic should worry about.

Of course, I should have thought about that and read the issue description properly. I'll have something alternative to look at later today.

tdiesler avatar Jun 17 '24 09:06 tdiesler

:warning: Unit test coverage report - coverage decreased from 39.9% to 39.8% (-0.1%)

github-actions[bot] avatar Jun 17 '24 10:06 github-actions[bot]

Failed (unrelated) in ... ❌ TestOLMOperatorUpgrade

tdiesler avatar Jun 19 '24 07:06 tdiesler

Superseded by #5754

squakez avatar Aug 08 '24 12:08 squakez