camel-k icon indicating copy to clipboard operation
camel-k copied to clipboard

chore(builder): add -DskipTests

Open squakez opened this issue 1 year ago • 3 comments

We have no reason to try executing any test as we don't expect the presence of any test at all

The operator output is now the following one:

camel-k-operator-5f5bf4f7bb-2w2tz camel-k-operator {"level":"info","ts":"2024-05-31T09:27:58Z","logger":"camel-k.maven.build","msg":"--- maven-surefire-plugin:2.12.4:test (default-test) @ camel-k-integration ---"}
camel-k-operator-5f5bf4f7bb-2w2tz camel-k-operator {"level":"info","ts":"2024-05-31T09:27:59Z","logger":"camel-k.maven.build","msg":"Tests are skipped."}
camel-k-operator-5f5bf4f7bb-2w2tz camel-k-operator {"level":"info","ts":"2024-05-31T09:27:59Z","logger":"camel-k.maven.build","msg":""}
camel-k-operator-5f5bf4f7bb-2w2tz camel-k-operator {"level":"info","ts":"2024-05-31T09:27:59Z","logger":"camel-k.maven.build","msg":"--- maven-jar-plugin:2.4:jar (default-jar) @ camel-k-integration ---"}
camel-k-operator-5f5bf4f7bb-2w2tz camel-k-operator {"level":"info","ts":"2024-05-31T09:27:59Z","logger":"camel-k.maven.build","msg":"Tests are skipped."}
camel-k-operator-5f5bf4f7bb-2w2tz camel-k-operator {"level":"info","ts":"2024-05-31T09:27:59Z","logger":"camel-k.maven.build","msg":""}

Closes #5472

Release Note

chore(builder): add -DskipTests

squakez avatar May 31 '24 08:05 squakez

@lburgazzoli do you think is this enough to solve the issue reported? It seems the execution of those mojos is skipped, but I am not sure if you were thinking in solving this problem differently. Do you mind having a look?

squakez avatar May 31 '24 09:05 squakez

:heavy_check_mark: Unit test coverage report - coverage increased from 39% to 39.1% (+0.1%)

github-actions[bot] avatar May 31 '24 09:05 github-actions[bot]

it probably won't impact our case but maven.test.skip is probably a better option

lburgazzoli avatar May 31 '24 13:05 lburgazzoli

Change done. Execution is showing the following:

camel-k-operator-5f5bf4f7bb-8hhvb camel-k-operator {"level":"info","ts":"2024-06-03T09:40:54Z","logger":"camel-k.maven.build","msg":"Not copying test resources"}
camel-k-operator-5f5bf4f7bb-8hhvb camel-k-operator {"level":"info","ts":"2024-06-03T09:40:54Z","logger":"camel-k.maven.build","msg":""}
camel-k-operator-5f5bf4f7bb-8hhvb camel-k-operator {"level":"info","ts":"2024-06-03T09:40:54Z","logger":"camel-k.maven.build","msg":"--- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ camel-k-integration ---"}
camel-k-operator-5f5bf4f7bb-8hhvb camel-k-operator {"level":"info","ts":"2024-06-03T09:40:54Z","logger":"camel-k.maven.build","msg":"Not compiling test sources"}
camel-k-operator-5f5bf4f7bb-8hhvb camel-k-operator {"level":"info","ts":"2024-06-03T09:40:54Z","logger":"camel-k.maven.build","msg":""}
camel-k-operator-5f5bf4f7bb-8hhvb camel-k-operator {"level":"info","ts":"2024-06-03T09:40:54Z","logger":"camel-k.maven.build","msg":"--- maven-surefire-plugin:2.12.4:test (default-test) @ camel-k-integration ---"}
camel-k-operator-5f5bf4f7bb-8hhvb camel-k-operator {"level":"info","ts":"2024-06-03T09:40:55Z","logger":"camel-k.maven.build","msg":"Tests are skipped."}
camel-k-operator-5f5bf4f7bb-8hhvb camel-k-operator {"level":"info","ts":"2024-06-03T09:40:55Z","logger":"camel-k.maven.build","msg":""}

squakez avatar Jun 03 '24 09:06 squakez

Failing check: https://github.com/apache/camel-k/issues/5521

squakez avatar Jun 03 '24 13:06 squakez