camel-k icon indicating copy to clipboard operation
camel-k copied to clipboard

feat(trait): jvm refactoring

Open squakez opened this issue 1 year ago • 9 comments

  • Added jar parameter which can be used with synthetic Kits
  • Deprecated print-command in order to let distroless to work OOTB

Ref #5476

Release Note

feat(trait): jvm refactoring

squakez avatar May 09 '24 09:05 squakez

:heavy_check_mark: Unit test coverage report - coverage increased from 38.1% to 38.3% (+0.2%)

github-actions[bot] avatar May 09 '24 09:05 github-actions[bot]

:heavy_check_mark: Unit test coverage report - coverage increased from 38.1% to 38.3% (+0.2%)

github-actions[bot] avatar May 09 '24 10:05 github-actions[bot]

:heavy_check_mark: Unit test coverage report - coverage increased from 38.1% to 38.3% (+0.2%)

github-actions[bot] avatar May 09 '24 16:05 github-actions[bot]

:heavy_check_mark: Unit test coverage report - coverage increased from 38.4% to 38.6% (+0.2%)

github-actions[bot] avatar May 21 '24 11:05 github-actions[bot]

I think the failures checks we're hitting is because of this joor issue: https://github.com/jOOQ/jOOR/issues/69

squakez avatar May 21 '24 15:05 squakez

:heavy_check_mark: Unit test coverage report - coverage increased from 38.4% to 38.6% (+0.2%)

github-actions[bot] avatar May 22 '24 11:05 github-actions[bot]

Configmap tests are failing because when we use the fast-jar, the resources provided in the classpath are not "visible" to the route directly. The following one is failing (java -cp ... -jar dependencies/quarkus-run.jar):

...
      - setBody:
          simple: "resource:classpath:my-configmap-key"
...

with:

[2] Caused by: java.io.FileNotFoundException: Cannot find resource: classpath:my-configmap-key for URI: classpath:my-configmap-key
[2] 	at org.apache.camel.support.ResourceHelper.resolveMandatoryResourceAsInputStream(ResourceHelper.java:114)
[2] 	at org.apache.camel.support.LanguageSupport.loadResource(LanguageSupport.java:74)

The same is working correctly with explicit execution (ie, java -cp ... io.quarkus.bootstrap.runner.QuarkusEntryPoint)

squakez avatar May 23 '24 08:05 squakez

Given the problems found so far, I'm moving the code developed into https://github.com/squakez/camel-k/tree/feat/5476_executable_jar for future references. I've created a follow up issue that we need to tackle in the future #5539 - for this PR I'm reducing the scope in order to be able to let the user fine tune the trait, have the possibility to run with a synthetic IntegrationKit and add some more coverage.

squakez avatar May 23 '24 10:05 squakez

:heavy_check_mark: Unit test coverage report - coverage increased from 38.4% to 38.6% (+0.2%)

github-actions[bot] avatar May 23 '24 10:05 github-actions[bot]

:heavy_check_mark: Unit test coverage report - coverage increased from 38.4% to 38.6% (+0.2%)

github-actions[bot] avatar May 27 '24 11:05 github-actions[bot]

:heavy_check_mark: Unit test coverage report - coverage increased from 38.4% to 38.6% (+0.2%)

github-actions[bot] avatar May 27 '24 11:05 github-actions[bot]

:heavy_check_mark: Unit test coverage report - coverage increased from 38.4% to 38.6% (+0.2%)

github-actions[bot] avatar May 27 '24 14:05 github-actions[bot]

:heavy_check_mark: Unit test coverage report - coverage increased from 38.4% to 38.6% (+0.2%)

github-actions[bot] avatar May 28 '24 10:05 github-actions[bot]

:heavy_check_mark: Unit test coverage report - coverage increased from 38.4% to 38.6% (+0.2%)

github-actions[bot] avatar May 28 '24 13:05 github-actions[bot]