camel-k icon indicating copy to clipboard operation
camel-k copied to clipboard

[chore] improve metrics for integration

Open lgarciaaco opened this issue 1 year ago • 3 comments

Improve metrics for integrations, record a counter with integration_name and state

This PR expands the metrics endpoint, now exposing a counter for the combination integration_name and integration_phase. The output looks like:

curl -s localhost:8080/metrics | grep -v "# " | grep integration_phase
camel_k_integration_phase{id="hello",phase="running"} 1
camel_k_integration_phase{id="hello-1",phase="error"} 5
camel_k_integration_phase{id="hello-1",phase="running"} 2

Release Note

NONE

lgarciaaco avatar Feb 13 '24 10:02 lgarciaaco

Fixes https://github.com/apache/camel-k/issues/5120

lgarciaaco avatar Feb 13 '24 10:02 lgarciaaco

@squakez I included all your recommendations

lgarciaaco avatar Feb 22 '24 12:02 lgarciaaco

@lgarciaaco please, rebase against main as we have fixed the errored check.

squakez avatar Feb 23 '24 10:02 squakez

:warning: Unit test coverage report - coverage decreased from 37.1% to 36.9% (-0.2%)

github-actions[bot] avatar Mar 12 '24 10:03 github-actions[bot]

@lgarciaaco I was about to merge but it seems there are merge conflicts could you please rebase against main? also, please, squash your commits to be a single one to have a cleaner history.

squakez avatar Mar 19 '24 12:03 squakez

To be squashed and merged once checks pass after the rebase. Thanks.

squakez avatar Mar 19 '24 14:03 squakez