Allow to use the Toolimage specified in the provided buildconfig

[rodcloutier]

This PR proposed to honor the configurationBuild field that can be used to provide a custom builder image.

Currently we provide a field ToolImage that can be used to specify the image used by the builder. In the code, we specifically ignore the provided image and impose the operator image.

The proposed changes will only use the operator image if the ToolImage field is not specified.

In our current settings, it is actually the same behaviour that was expressed: we use the operator image as the ToolImage field.

We could also deprecate the ToolImage field to express that the usage will not be honoured.

Release Note

NONE

[rodcloutier]

Thanks for the insight. Could we then deprecate, and eventually remove, the ToolImage field in the BuildConfiguration? It seems, from my understanding, that there is no use for it.

We explicitly assign the value as the operator image in one and only one place.

[squakez]

Thanks for the insight. Could we then deprecate, and eventually remove, the ToolImage field in the BuildConfiguration? It seems, from my understanding, that there is no use for it.

We explicitly assign the value as the operator image in one and only one place.

We can't. We don't know ahead of time which is the container/version the operator is running. With this design, we read it at runtime and make sure that it is always the same for which the operator is running.

[github-actions[bot]]

This PR has been automatically marked as stale due to 90 days of inactivity. It will be closed if no further activity occurs within 15 days. If you think that’s incorrect or the issue should never stale, please simply write any comment. Thanks for your contributions!