camel-k
camel-k copied to clipboard
fix(knative): Make knative broker name configurable
https://github.com/apache/camel-k/issues/2864
- Add e2e knative tests
- Change the kamelet-binding-broker yaks test to use a custom broker name
Release Note
Make knative broker name configurable
- WIP: This PR depends on a camel-knative fix. This is for an early review.
@christophd @squakez for review.
@claudio4j many thanks! some e2e tests failed. is this because the fixed Camel component is not part of Camel K yet?
some e2e tests failed. is this because the fixed Camel component is not part of Camel K yet?
Yes, we should wait the release train of camel artifacts.
@claudio4j will users of the component be able to listen for all events on a broker with this fix, too? At the moment users need to filter for a given event type and can not listen for all events on that broker.
@claudio4j will users of the component be able to listen for all events on a broker with this fix, too?
Yes, there is a e2e knative-broker test that checks all messages are received.
At the moment users need to filter for a given event type and can not listen for all events on that broker.
No need for filtering to listen for all events, the following trigger spec was generated by camel-k-operator.
spec:
broker: example-broker
filter: {}
subscriber:
ref:
apiVersion: serving.knative.dev/v1
kind: Service
name: receiver-example
namespace: default
uri: /events/
@claudio4j awesome! this is a much appreciated enhancement
@claudio4j can we rebase this please?
@claudio4j can we rebase this please?
rebased.
I see all of the failing CI tests are timeouts.
For what I could see, the check errors are the same we are experincing on main (likely releated to the new runtime?). I'm merging also this and we can focus on fixing directly any error on main