camel-k icon indicating copy to clipboard operation
camel-k copied to clipboard

chore(build): let bom managed by camel k runtime

Open squakez opened this issue 3 years ago • 4 comments

With this PR, we remove the dependency from the platform. We'll let the runtime to manage them accordingly. It will also require some change on Camel K Runtime https://github.com/apache/camel-k-runtime/pull/827

Release Note

chore(build): let bom managed by camel k runtime

squakez avatar May 30 '22 14:05 squakez

fyi @lburgazzoli @astefanutti @ppalaga @jamesnetherton @oscerd

squakez avatar May 30 '22 14:05 squakez

I think this is failing because we need the changes in https://github.com/apache/camel-k-runtime/pull/827 to be available. @oscerd which would be the best strategy to use a new change in the camel k runtime? putting this on hold until the camel k runtime is released? Thanks.

squakez avatar May 31 '22 06:05 squakez

I think this is failing because we need the changes in apache/camel-k-runtime#827 to be available. @oscerd which would be the best strategy to use a new change in the camel k runtime? putting this on hold until the camel k runtime is released? Thanks.

Yes, for the moment.

oscerd avatar Jun 13 '22 04:06 oscerd

Moving as a draft to avoid any unintentional merge. It will need to be merged during next 1.10 release cycle, as soon as camel k runtime version is officially released as well.

squakez avatar Jun 13 '22 07:06 squakez

@squakez can we rebase this and make it ready for review?

oscerd avatar Aug 23 '22 04:08 oscerd

Root cause failures are:

org.graalvm.polyglot.PolyglotException: java.lang.IllegalStateException: Duplicate language id regex. First language [Language class com.oracle.truffle.regex.RegexLanguage, Loaded from file:/deployments/dependencies/lib/main/org.graalvm.regex.regex-22.1.0.jar]. Second language [Language class com.oracle.truffle.regex.RegexLanguage, Loaded from file:/deployments/dependencies/lib/main/org.graalvm.regex.regex-22.1.0.jar].

However it seems they are the same of the ones happening in the main branch. I suggest to merge and solve in the main branch.

squakez avatar Aug 24 '22 13:08 squakez

ok, let's merge.

oscerd avatar Aug 24 '22 13:08 oscerd