camel-k icon indicating copy to clipboard operation
camel-k copied to clipboard

`make build-resources` does not work on Windows

Open astefanutti opened this issue 3 years ago • 12 comments

The build on Windows fails because the build-resources target fails. The package name computed in the following location is not correct:

https://github.com/apache/camel-k/blob/8fcf47c258c00ae3671929ba018ba8aeee79772d/cmd/util/vfs-gen/main.go#L117

astefanutti avatar Mar 27 '22 17:03 astefanutti

I was experiencing the same issue and looking for solutions; I'd want to address this because my primary development environment is on a Windows PC. @astefanutti, could you kindly offer a brief description of the prospective solution you want, as well as any references?

whtssub avatar Mar 27 '22 17:03 whtssub

@SubhasmitaSw I can see two possible work-around that I'd like to be confirmed:

  • Copy the script/Makefile into the project root directory and try to run from there
  • Overwrite the Makefile symlink at the project root directory with one created by mklink: https://docs.microsoft.com/fr-fr/windows-server/administration/windows-commands/mklink

Another option would be to run the commands from the script directory, but that requires to make all the paths relative to the location of the Makefile, which may not be straightfoward: https://stackoverflow.com/questions/18136918/how-to-get-current-relative-directory-of-your-makefile

astefanutti avatar Mar 27 '22 17:03 astefanutti

@astefanutti could you please assign this to me, I'd start working on it. Thanks!

whtssub avatar Mar 27 '22 17:03 whtssub

@SubhasmitaSw great, assigned :)

astefanutti avatar Mar 27 '22 17:03 astefanutti

@astefanutti this issue description should now be changed to address the major problem, isn't it?

whtssub avatar Apr 09 '22 06:04 whtssub

@SubhasmitaSw I've updated the issue title and description. Let me know if that's correct.

astefanutti avatar Apr 11 '22 07:04 astefanutti

@astefanutti Yes, It looks good now. One things, is this still to be considered a good-first-issue?

whtssub avatar Apr 11 '22 08:04 whtssub

@astefanutti Yes, It looks good now. One things, is this still to be considered a good-first-issue?

@SubhasmitaSw I was inclined to be optimistic, but I infer from your comment that you suggest it may not qualify :) I trust your feedback and let's remove the label 👍🏼.

astefanutti avatar Apr 11 '22 10:04 astefanutti

This issue has been automatically marked as stale due to 90 days of inactivity. It will be closed if no further activity occurs within 15 days. If you think that’s incorrect or the issue should never stale, please simply write any comment. Thanks for your contributions!

github-actions[bot] avatar Jul 11 '22 00:07 github-actions[bot]

Do we have the lifecycle/frozen state?

whtssub avatar Jul 12 '22 08:07 whtssub

@SubhasmitaSw Do you mean status/never-stale?

tadayosi avatar Jul 12 '22 08:07 tadayosi

@tadayosi yes, we should update this issue to this status.

whtssub avatar Jul 12 '22 09:07 whtssub

Fixing this issue while looking into #3364

phantomjinx avatar Oct 17 '22 16:10 phantomjinx

https://github.com/apache/camel-k/pull/3823

phantomjinx avatar Nov 18 '22 12:11 phantomjinx

According to the last comment, this is solved. Closing.

squakez avatar Sep 15 '23 08:09 squakez