camel-k
camel-k copied to clipboard
[Trait] maven repo and service account encapsulation
Also, in that spirit of moving / "encapsulating" the configurability responsibility to the traits, it may be logical to:
- Move the
.spec.repositoriesfield (Maven repositories) into the builder trait - Move the
.spec.serviceAccountNamefield into the pod trait
Originally posted by @astefanutti in https://github.com/apache/camel-k/issues/2003#issuecomment-843983721
Likewise I'd like to see the entire Maven settings are encapsulated into a trait, as I see mirroring of Maven repos is essential for day-to-day Camel K development. Can it be also in the scope of this issue? https://camel.apache.org/camel-k/latest/configuration/maven.html
I think they are 2 different things. Whilst the whole maven configuration is something applicable at IntegrationPlatform level (basically influencing the operator), here the focus is on those fields that are configured on the Integration. I am not sure if, technically speaking, we can mix both aspects.
@squakez Alright. I see that maven settings are IntegrationPlatform level and thus should be kept in kamel install command parameters. Thanks for the clarification.
The .spec.repositories field from the IntegrationKit API should probably also be removed, as identified in #2328 by @johnpoth.
This issue has been automatically marked as stale due to 90 days of inactivity. It will be closed if no further activity occurs within 15 days. If you think that’s incorrect or the issue should never stale, please simply write any comment. Thanks for your contributions!
This issue has been automatically marked as stale due to 90 days of inactivity. It will be closed if no further activity occurs within 15 days. If you think that’s incorrect or the issue should never stale, please simply write any comment. Thanks for your contributions!