camel-k icon indicating copy to clipboard operation
camel-k copied to clipboard

Support for AWS ECR in kaniko builder in Operator

Open dylanenabled opened this issue 6 years ago • 6 comments

Currently the kaniko builder only supports pushing images to Google.

I'd like it if kaniko could push builds to AWS ECR. It looks like this is fairly straightforward to implement in the kaniko image as described in the documentation.

It looks like being able to define a --registryDockerConfig parameter when installing the platform (via kamel install) would work. This could save a provided docker config.json to a configmap, and then mounts it at /kaniko/.docker in the build image, similar to how the kaniko secret is saved.

The aws account credentials could be saved similarly to how it is done for GCR. instead mounted to /root/.aws. This could be optional however because the IAM credentials could also be provided to the builder by EKS via the IAM integration using the camel-k-builder serviceaccount if the cluster has that set up (see #1030).

More generically I guess, some way of defining secret and configmap mounts for the builder containers would also work.

dylanenabled avatar Oct 30 '19 10:10 dylanenabled

Looks like #1084 implements this?

EDIT: looks like it still needs a way of either setting the builder pod's serviceaccount (the preferred method, related to #1030 but for builders) or otherwise mounting an AWS secret file into the builder container at /root/.aws/credentials in order to work.

dylanenabled avatar Feb 13 '20 06:02 dylanenabled

This issue has been automatically marked as stale due to 90 days of inactivity. It will be closed if no further activity occurs within 15 days. If you think that’s incorrect or the issue should never stale, please simply write any comment. Thanks for your contributions!

github-actions[bot] avatar Feb 06 '22 00:02 github-actions[bot]

Any news on this? This will be highly valuable and enable a lot of AWS EKS/ECR users to use camelk

Richardmbs12 avatar Apr 23 '22 18:04 Richardmbs12

We have no documentation related to that platform unfortunately. Contributions are very welcome.

squakez avatar Apr 25 '22 08:04 squakez

This issue has been automatically marked as stale due to 90 days of inactivity. It will be closed if no further activity occurs within 15 days. If you think that’s incorrect or the issue should never stale, please simply write any comment. Thanks for your contributions!

github-actions[bot] avatar Jul 29 '22 00:07 github-actions[bot]

Had to move to normal camel 🙁

Richardmbs12 avatar Jul 29 '22 05:07 Richardmbs12

This issue has been automatically marked as stale due to 90 days of inactivity. It will be closed if no further activity occurs within 15 days. If you think that’s incorrect or the issue should never stale, please simply write any comment. Thanks for your contributions!

github-actions[bot] avatar Oct 29 '22 00:10 github-actions[bot]

I'd also like to see ECR being officially supported with Camel K.

kjozsa avatar Oct 29 '22 20:10 kjozsa

This issue has been automatically marked as stale due to 90 days of inactivity. It will be closed if no further activity occurs within 15 days. If you think that’s incorrect or the issue should never stale, please simply write any comment. Thanks for your contributions!

github-actions[bot] avatar Jan 29 '23 00:01 github-actions[bot]