[CALCITE-6301] Extend ‘Must-filter’ columns to support a conditional bypass list

[olivrlee]

[julianhyde]

Latest commit looks fairly close.

There needs to be an cogent explanation in the code for the concepts of bypass fields etc. The javadoc for class FilterRequirement seems like a good place. Add a couple of worked examples, like my 'table t has must-filter field f and bypass field b and the query "select ... from t" has ...'.

Move the current descriptions of the 3 fields onto the fields themselves.

'Remnant' is not a good name because it forces you to talk about how we got here - the winnowing algorithm - rather than there we are. I prefer 'anyFitlerFields' because for the query to be valid you need to filter any of them.

I think you can make FilterRequirement immutable if you have a subclass of SqlVisitor that has 3 mutable fields.

[sonarqubecloud[bot]]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions[bot]]

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

[olivrlee]

Still requires a review before final merge, but last commit was fairly close.