calcite icon indicating copy to clipboard operation
calcite copied to clipboard

CALCITE-6465: Rework code generator to use Flink code splitter

Open jduo opened this issue 1 year ago • 4 comments

jduo avatar Aug 02 '24 22:08 jduo

This builds but introduces a dependency on flink-core. Looking for a way around this.

jduo avatar Aug 02 '24 22:08 jduo

@rubenada @julianhyde , just wondering if there was some more feedback on this and would like some clarification on where system tests reside within Calcite. Thanks.

jduo avatar Oct 09 '24 16:10 jduo

@jduo , not sure what you mean by "system tests". If you want to add a test with a large dynamic code that fails when this feature is turn off / passes when it is turned on; maybe you could check and adapt the test that was done for the slightly related CALCITE-3094 (and then refined in CALCITE-6593 ): LargeGeneratedJoinTest. The query in that test, with the JOIN_SELECTOR_COMPACT_CODE_THRESHOLD disabled, should throw the "code grows beyond 64 KB InternalCompilerException". At that point, turning on the code splitter from this PR, should make the test pass.

rubenada avatar Oct 16 '24 07:10 rubenada

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Dec 05 '24 03:12 github-actions[bot]