calcite icon indicating copy to clipboard operation
calcite copied to clipboard

[CALCITE-6449] Enable PostgreSQL implementations of to_date/to_timestamp

Open normanj-bitquill opened this issue 1 year ago • 5 comments

  • Supports all date/time format patterns of PostreSQL 14
  • Oracle will use the existing implementations

normanj-bitquill avatar Jun 26 '24 20:06 normanj-bitquill

@normanj-bitquill I find it very convenient to first run ./gradlew build on my local machine before submitting a commit. This catches most of the problems, and is faster than the CI.

mihaibudiu avatar Jun 26 '24 21:06 mihaibudiu

@normanj-bitquill I find it very convenient to first run ./gradlew build on my local machine before submitting a commit. This catches most of the problems, and is faster than the CI.

I run that. The errors here are when it is run with the -PenableCheckerframework flag. I am running that locally now.

normanj-bitquill avatar Jun 26 '24 21:06 normanj-bitquill

the checkerframework is still not happy Please leave a note when this is ready for review

mihaibudiu avatar Jun 27 '24 18:06 mihaibudiu

@mihaibudiu Looks like I have resolved the checkerframework issues. Can you take another look?

Thank you for all of the help.

normanj-bitquill avatar Jun 27 '24 20:06 normanj-bitquill

Will you also add one of these nice .iq scripts that has been compared with Postgres?

@mihaibudiu I have added many tests for to_date and to_timestamp to the postgresql.iq file.

normanj-bitquill avatar Jul 08 '24 20:07 normanj-bitquill

I think that you can squash the commits. I don't know if you want more than 1 - up to you.

mihaibudiu avatar Jul 11 '24 05:07 mihaibudiu

The commits have been squashed.

normanj-bitquill avatar Jul 11 '24 19:07 normanj-bitquill