calcite [CALCITE-5976] Function ARRAY_PREPEND/ARRAY_APPEND/ARRAY_INSERT gives exception when inserted element type not equals array component type

[CALCITE-5976] Function ARRAY_PREPEND/ARRAY_APPEND/ARRAY_INSERT gives exception when inserted element type not equals array component type

Open caicancai opened this issue 1 year ago • 14 comments

https://issues.apache.org/jira/browse/CALCITE-5976

Feb 26 '24 15:02 caicancai

The code is very ugly, please do not review it, I will refactor it later.

Feb 28 '24 10:02 caicancai

The code is very ugly, please do not review it, I will refactor it later.

you can create a DRAFT PR when PR is not ready.

Feb 29 '24 03:02 chucheng92

@caicancai A suggestion, don’t directly @/pin committers to review for you. This will affect other committers or contributors’ participation in your reviews.

Feb 29 '24 06:02 chucheng92

@caicancai A suggestion, don’t directly @/pin committers to review for you. This will affect other committers or contributors’ participation in your reviews.

Thanks for your reminder

Feb 29 '24 06:02 caicancai

@caicancai please use correct/proper commit name when you fix code-reivews to add a new commit.

Mar 01 '24 06:03 chucheng92

@caicancai I have created a commit based on your PR. you can pick and take a look.

https://github.com/chucheng92/calcite/commit/12cd99c8b1397b643b6d842f58d0331f54b7cb09

Mar 01 '24 10:03 chucheng92

@caicancai I have created a commit based on your PR. you can pick and take a look. https://github.com/chucheng92/calcite/tree/CALCITE-5976

Thank you, very much appreciated

Mar 01 '24 12:03 caicancai

no comment. squashing

Mar 05 '24 00:03 caicancai

@caicancai please change your commit/pr name.

Mar 05 '24 02:03 chucheng92

@caicancai please change your commit/pr name.

Thank you

Mar 05 '24 05:03 caicancai

@chucheng92 I've added you as Co-authored, thank you very much

Mar 06 '24 07:03 caicancai

@caicancai looks good to me now. could you change commit name by using 'ARRAY_PREPEND/ARRAY_APPEND/ARRAY_INSERT'. These function names are usually capitalized in commit.

Mar 06 '24 08:03 chucheng92

@chucheng92 I fixed a similar problem. If you have time, can you help me take a look at this PR? Thank you. https://github.com/apache/calcite/pull/3721

Mar 10 '24 01:03 caicancai