calcite
calcite copied to clipboard
[CALCITE-6239] Add a postgis dialect that supports ST functions
In JDBC adapter, add a PostGIS dialect so that ST functions can be pushed down
@YiwenWu @JiajunBernoulli What would be the best way to test these changes against a postgis database? Ideally, I'd like to add an integration test that executes queries against postgis (e.g. with testcontainers). But I havn't been able to find such tests in calcite.
@YiwenWu @JiajunBernoulli What would be the best way to test these changes against a postgis database? Ideally, I'd like to add an integration test that executes queries against postgis (e.g. with testcontainers). But I havn't been able to find such tests in calcite.
I remember that testContainer has been used in redis apapter test.
@YiwenWu @JiajunBernoulli What would be the best way to test these changes against a postgis database? Ideally, I'd like to add an integration test that executes queries against postgis (e.g. with testcontainers). But I havn't been able to find such tests in calcite.
There are some integration tests for Druid: https://github.com/zabetak/calcite-druid-dataset Here is CI config in calcite: https://github.com/apache/calcite/blob/2aabf210dc1918c6ca20e63b39661ff445535eb8/.github/workflows/main.yml#L440
Thanks a lot for the pointer, I will adopt the same approach and implement some integration tests in a third-party repository for now.
Quality Gate passed
Issues
12 New issues
Measures
0 Security Hotspots
84.4% Coverage on New Code
0.0% Duplication on New Code
Will this be ready for 1.37?
No, I hadn't enought time to work on this and the decoupling of the GEOMETRY type from the JTS Geometry class will require additional efforts.
https://issues.apache.org/jira/browse/CALCITE-6239