calcite icon indicating copy to clipboard operation
calcite copied to clipboard

[CALCITE-6239] Add a postgis dialect that supports ST functions

Open bchapuis opened this issue 1 year ago • 7 comments

In JDBC adapter, add a PostGIS dialect so that ST functions can be pushed down

bchapuis avatar Feb 02 '24 22:02 bchapuis

@YiwenWu @JiajunBernoulli What would be the best way to test these changes against a postgis database? Ideally, I'd like to add an integration test that executes queries against postgis (e.g. with testcontainers). But I havn't been able to find such tests in calcite.

bchapuis avatar Feb 03 '24 10:02 bchapuis

@YiwenWu @JiajunBernoulli What would be the best way to test these changes against a postgis database? Ideally, I'd like to add an integration test that executes queries against postgis (e.g. with testcontainers). But I havn't been able to find such tests in calcite.

I remember that testContainer has been used in redis apapter test.

macroguo-ghy avatar Feb 04 '24 05:02 macroguo-ghy

@YiwenWu @JiajunBernoulli What would be the best way to test these changes against a postgis database? Ideally, I'd like to add an integration test that executes queries against postgis (e.g. with testcontainers). But I havn't been able to find such tests in calcite.

There are some integration tests for Druid: https://github.com/zabetak/calcite-druid-dataset Here is CI config in calcite: https://github.com/apache/calcite/blob/2aabf210dc1918c6ca20e63b39661ff445535eb8/.github/workflows/main.yml#L440

JiajunBernoulli avatar Feb 05 '24 01:02 JiajunBernoulli

Thanks a lot for the pointer, I will adopt the same approach and implement some integration tests in a third-party repository for now.

bchapuis avatar Feb 05 '24 10:02 bchapuis

Will this be ready for 1.37?

mihaibudiu avatar Apr 08 '24 22:04 mihaibudiu

No, I hadn't enought time to work on this and the decoupling of the GEOMETRY type from the JTS Geometry class will require additional efforts.

https://issues.apache.org/jira/browse/CALCITE-6239

bchapuis avatar Apr 09 '24 07:04 bchapuis