[CALCITE-6226] Wrong ISOWEEK and no ISOYEAR on BigQuery FORMAT_DATE

[rorueda]

https://issues.apache.org/jira/browse/CALCITE-6226

[sonarqubecloud[bot]]

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

6 New issues
0 Security Hotspots
83.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[rorueda]

Since I had to rebase it onto master to address the last change request, I squashed the commits.

[julianhyde]

It always struck me as strange that this change is using Calendar. Day of the week is simple if you convert to Julian date. JulianOn Mar 9, 2024, at 07:59, rorueda @.***> wrote: @rorueda commented on this pull request.

In core/src/test/java/org/apache/calcite/util/format/FormatElementEnumTest.java:

 assertFormatElement(FormatElementEnum.IW, "2014-09-30T10:00:00Z", "40");

• // edge case where ISO WEEK != WEEK

I added additional test cases, all manually validated against BigQuery.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

[sonarqubecloud[bot]]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud