calcite icon indicating copy to clipboard operation
calcite copied to clipboard
verified publisher icon apache

[CALCITE-5991] Reduce the number of tasks related to AbstractConverter in TopDownRuleDriver

Open asdfgh19 opened this issue 2 years ago • 6 comments

jira: CALCITE-5991

This PR is based on the following facts.

  1. AbstractConverter is not an instance of PhysicalNode. So we don't have to try to passThrough or derive Trait on it.
  2. AbstractConverter must only exist in the root RelSet, and its TraitSet must be equal to the TraitSet of the root RelSubset group.

asdfgh19 avatar Sep 10 '23 07:09 asdfgh19

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 10 '23 08:09 sonarqubecloud[bot]

Could you add the unit test for you logic?

LakeShen avatar Sep 10 '23 09:09 LakeShen

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Dec 30 '24 03:12 github-actions[bot]

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Mar 20 '25 03:03 github-actions[bot]

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Jun 28 '25 03:06 github-actions[bot]

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Oct 26 '25 03:10 github-actions[bot]