calcite icon indicating copy to clipboard operation
calcite copied to clipboard

[CALCITE-5937] The parsing error should not be thrown even if there is empty Hint

Open LakeShen opened this issue 2 years ago • 7 comments

Now in the calcite,for the following sql query, it would throw an SQL parsing error:

select /*+ */ deptno, min(foo) as x from emp  

After this PR,above sql is successed to parse.

LakeShen avatar Aug 18 '23 14:08 LakeShen

implementation is good. but why this matters, is it a standard or something?

zinking avatar Aug 19 '23 06:08 zinking

Hi @zinking ,I think Hint is a special kind of SQL comment,so even if there is no Hint in Hint Statement,it should not affect the sql execution.This behavior is the same as ORACLE hints.

Here is the oracle hint description: image

More details could see :https://docs.oracle.com/cd/E11882_01/server.112/e41084/sql_elements006.htm#SQLRF51098

LakeShen avatar Aug 19 '23 13:08 LakeShen

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Dec 30 '24 03:12 github-actions[bot]

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Mar 20 '25 03:03 github-actions[bot]

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Jun 28 '25 03:06 github-actions[bot]

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Oct 26 '25 03:10 github-actions[bot]