calcite icon indicating copy to clipboard operation
calcite copied to clipboard

[CALCITE-5840] Incorrect SOUNDEX function semantics in MySQL library

Open chucheng92 opened this issue 2 years ago • 5 comments

What is the purpose of the change

https://issues.apache.org/jira/browse/CALCITE-5840

The SqlFunctions#soundexMySQL rewrite the mysql's c++ soundex implementation. pls see: https://github.com/mysql/mysql-server/blob/ea1efa9822d81044b726aab20c857d5e1b7e046a/sql/item_strfunc.cc#L2054

Brief change log

Add a new mysql soundex implementation to correct current wrong behavior in calcite.

Verifying this change

SqlOperatorTests#testMysqlSoundex()

chucheng92 avatar Aug 04 '23 15:08 chucheng92

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Dec 30 '24 03:12 github-actions[bot]

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Mar 20 '25 03:03 github-actions[bot]

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Jun 29 '25 03:06 github-actions[bot]

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Oct 26 '25 03:10 github-actions[bot]