apache
CALCITE-5860 Set scale when casting Decimal
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells
96.0% Coverage
0.0% Duplication
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells
97.1% Coverage
0.0% Duplication
Overall the changes LGTM, however when I apply locally the patch for CALCITE-5923, which makes all the tests under SqlOperatorTest run as expected, I get some errors.
./gradlew cleanTest :core:test --tests CalciteSqlOperatorTest@pfzhan Can you please check if those errors are related with the changes here?
I pulled the latest code locally and ran this command and it was OK.
BUILD SUCCESSFUL in 56s 74 actionable tasks: 19 executed, 3 from cache, 52 up-to-date The remote build cache was disabled during the build due to errors. (base) ➜ calcite git:(CALCITE-5860)
Due to the bug reported under CALCITE-5923 the tests that rely on safeParameters method are not running as expected. Basically, without the fix in CALCITE-5923, the tests will only pass from the validator; executable code is not generated so basically the actual results are not checked.
If you want to test your changes properly you will have to apply "temporarily" the proposed fix in CALCITE-5923 and then run CalciteSqlOperatorTest.
@pfzhan Now that CALCITE-5923 is committed you can revert https://github.com/apache/calcite/pull/3326/commits/c976ef4ff24966418553807b9e576a0d3c433cd7 and continue the work as usual. Ping me again once you address the test failures. Thanks!
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.