Draft pr to simplify and fix ORDER BY ordinal issues

[jhugomoore]

Exploring what would have to change in ReltoSqlConverterTest in order to simplify SqlImplementor->Context->orderField.

Current findings Tests that seem to be caused by bugs

• testConvertWindowToSql Put in fix for egregious issue of (group by 10) in query 1. Ignore ordinals when in an aliasContext was fix. Don’t know enough about what it’s doing in the rest to be sure if they’re correct. 6 & 8 definitely seem wrong
• testMySqlUnparseListAggCall listagg() order by shouldn't be ordinals, seems needlessly confusing
• PigRelOpTest -> testForEachNested Confusing change, doesn't seem to match anything else.
• PigRelOpTest -> testRank() Inserts Ordinals that don't exist

Tests that insert a pretty crazy select clause, not sure if it’s what we want

• testOrderByNotInSelectList
• testRewriteOrderByWithNumericConstants
• testSelectQueryWithAscDescOrderByClause
• testSelectQueryWithLimitOffsetClause
• testSelectQueryWithTwoOrderByClause

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

100.0% Coverage
0.0% Duplication

[github-actions[bot]]

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

[github-actions[bot]]

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

[github-actions[bot]]

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

[github-actions[bot]]

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.